Fixed small syntax errors in ODIN's Makefile test target. #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alirezazd - Can you please update the branch with the master branch, then we will rerun the CI test? It seems there is a mismatch for the nightly test 1 results. |
alirezazd
force-pushed
the
ODIN_Makefile_fix
branch
from
a8e2595 to
fb75430
Compare
github-actions
bot
removed
VPR
|
@sdamghan Thank you, I have updated my branch. Please re-run the test. |
alirezazd
force-pushed
the
ODIN_Makefile_fix
branch
from
ba55535 to
dbafec6
Compare
|
LGTM, will merge once all CIs are green |
|
@mithro This PR is ready to merge, JFYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build the test target with the ODIN's Makefile, encountered a syntax error which I fixed.
Description
I have made the same edit on two lines of the Makefile.
Related Issue
Motivation and Context
It resoves the error when trying to make the test target.
How Has This Been Tested?
The "make test" command now works and starts the benchmarks.
Types of changes
Checklist: